JAVA string validation

Cr8or

Im doing some string validation to validate for only numbers as seen below. Im prob doing somthing quite silly but when I enter a number above 9 ie 10 + my code loops back around again. Anyone got any ideas?

    public static int valid(String string) {
        
        String text;
        int option = 0;
        
        text = JOptionPane.showInputDialog(string);
        
        while (option < 1) {

            while (!text.matches("\\d")) {
                
                    JOptionPane.showMessageDialog(null, "Invalid selection please try again.", "xxx", JOptionPane.ERROR_MESSAGE);
                
                    text = JOptionPane.showInputDialog(string);
                    
                    if (text == null) {

                        JOptionPane.showMessageDialog(null, "Invalid selection please try again.", "xx", JOptionPane.ERROR_MESSAGE);
                        
                        menu();    
                        
                    }
             
            }
            
            option = Integer.parseInt(text);
            
        }
        
        return option;
        
    }

Hobbes

while (!text.matches("\\d")) {

\\d refers only to one digit. For ten you would need "\\d\\d".

pH

How about ...

"\\d\\d*"

to match any valid number (1 digit or more)

Cr8or

nice one thanks .. thought that might be the problem .. wasnt sure how to get around it.

its working now this also seemed to work.

\\d*

Draupnir

\\d* may return true for 0 instances of the digit I believe, so beware of false positives.

ishnid

Yeah - \\d* also matches empty strings, use \\d+