Bracketing loops and if statements (Java)

Joneser

Hi, I was just wondering if the only reason for bracketing statements and loops was for clarity, i bracket them but noticed in some sample code that alot of people dont.

eg, I would would write an if statement like this:

if(a+b = c){
System.out.println(c + "is the sum of " + a + " and " + b);
}

But other people write like this:

if(a+b = c)
System.out.println(c + "is the sum of " + a + " and " + b);


Just wondering if there is a real reason for using one over the other or if its only personal preference, thanks in advance

Reku

If the command to be followed if the condition applies is only one line you don't need brackets, more than one line you do.

e.g.
if x is true
do this;
else
do this;


if y is true
{
do this;
and this;
}


TBH I still use brackets even for one line commands as I find it easier to read.

Royale with Cheese

Yeah I was wondering this myself as recently I was using some code somebody else had written without brackets. I agree with farohar, I'd always use them for better clarity.

Eoin

The only time I might not bracket my code is if I know I would never have to add any debugging code later, and then I would put it on one line rather than over two lines.

if(a+b = c) System.out.println(c + "is the sum of " + a + " and " + b);

Joneser

Thanks for clearing that up, i thought it was just for clarity myself but wanted to make sure, cheers

Pygmalion

They ARE needed if there's more than one line to be executed in the if statement.

And the way I see it, if you're going to need them sometimes why not put them in all the time instead of being inconsistent about it?
Any time it's ever mentioned everyone seems to agree it's a lot easier to read with the brackets in.

DonkeyStyle \o/

eoin wrote: »

The only time I might not bracket my code is if I know I would never have to add any debugging code later, and then I would put it on one line rather than over two lines.

Same here, although if the line gets a bit long, I'll do a line-break and indent the next line... I find it pretty clear.

if(whatever)
    blah = something;
else
    blah = yadda;

Eoin

I would use brackets in your example - I only use a one liner for the simplest of statements.

none

eoin wrote: »

The only time I might not bracket my code is if I know I would never have to add any debugging code later, and then I would put it on one line rather than over two lines.

if(a+b = c) System.out.println(c + "is the sum of " + a + " and " + b);

Just to clarify that it's not about number of lines but rather statements. If only one statement, braces are optional, otherwise - mandatory. The number of lines is irrelevant, really.
Another thing is that condition (if(a+b = c)) is invalid regardless of the data types used. Single "=" is an assignment operators while double "==" is the relational one (required here).

Eoin

none wrote: »

Just to clarify that it's not about number of lines but rather statements. If only one statement, braces are optional, otherwise - mandatory. The number of lines is irrelevant, really.

I agree, I was just saying that I always use brackets, unless it happens to be a very simple line of code that would never require debugging and would be very clear to someone else looking at the code.

none wrote: »

Another thing is that condition (if(a+b = c)) is invalid regardless of the data types used. Single "=" is an assignment operators while double "==" is the relational one (required here).

I just copied in the code from the OP.

none

eoin wrote: »

I just copied in the code from the OP.

Sorry for the confusion, of course, it's all for the attention of the OP, I copied your code because it was closest to the end

Kidchameleon

I always use brackets. Makes it nicer to read and makes your code more maintainable. You never know if a one liner could grow into more over the years...

Herbal Deity

I used to be in the "always use them" camp. But recently, I think omitting them in certain situations is nice and very readable. Like, when I see:

if (x)
{
  y
}

I think "what was the point of those superfluous braces?".

*shrug, personal preference I guess.

fasty

I prefer leaving out the braces for single statements for readability reasons too...

if(pThing) pThing->SomeFunction();

is easier to read than the following...

if(pThing)
{
    pThing->SomeFunction();
}

Eoin

I don't think it's much easier to read, but it's a bit neater.

I do hate reading someone's code when there's something like a loop with no brackets (especially a nested one). Many editors show the start or end bracket when you hover over or click on the corresponding bracket, and I don't know if it's as easy to figure out with no brackets.