Advertisement
If you have a new account but are having problems posting or verifying your account, please email us on hello@boards.ie for help. Thanks :)
Hello all! Please ensure that you are posting a new thread or question in the appropriate forum. The Feedback forum is overwhelmed with questions that are having to be moved elsewhere. If you need help to verify your account contact hello@boards.ie
A hand with a Processing sketch
Options
-
11-08-2011 9:51pm#1Hello all!
I am trying to make a basic pitch tone tester in Processing.
It is working, I need to make a basic GUI for it, but I was just wondering if you guys could find places to optimise the code, which I am sure is almost everywhere
I am not too sure if this is the right place for this though.
Thanks all!
bbkimport ddf.minim.*;
import ddf.minim.signals.*;
Minim minim;
AudioOutput out;
SineWave sine;
SineWave sine2;
float n1;
float n2;
float s1;
float s2;
int lowmin;
int lowmax;
int highmin;
int highmax;
int a;
int b;
int c;
int d;
float low;
float high;
int level;
void setup()
{
size(512, 200, P2D);
low = 400;
high = 600;
println("Void Setup");
println("Low = " + low);
println("High = " + high);
println(" ");
n1 = low;
n2 = high;
float[] sinesource = new float [2];
sinesource[0] = n1;
sinesource[1] = n2;
s1 = sinesource[int(random(0,2))];
println("Sine Source 1 " + s1);
if(s1 == n1) {
s2 = n2;
}
else {
s2 = n1;
}
println("Sine Source 2 " + s2);
minim = new Minim(this);
out = minim.getLineOut(Minim.STEREO);
// println("Welcome to the pitch trainer app. The aim of this is to train your ears to detect tiny differences in pitch. Please press 'S' to start");
}
void draw()
{
background(0);
stroke(255);
if(keyPressed) {
if (key == 's' || key == 'S') {
println("Void Draw");
println("Low = " + low);
println("High = " + high);
println("LEVEL " + level);
println(" ");
n1 = low;
n2 = high;
float[] sinesource = new float [2];
sinesource[0] = n1;
sinesource[1] = n2;
s1 = sinesource[int(random(0,2))];
println("Sine Source 1 " + s1);
if(s1 == n1) {
s2 = n2;
}
else {
s2 = n1;
}
println("Sine Source 2 " + s2);
sine = new SineWave(s1, 0, out.sampleRate());
sine2 = new SineWave(s2, 0, out.sampleRate());
out.addSignal(sine);
out.addSignal(sine2);
sine.setAmp(0.5);
delay(1500);
sine.setAmp(0);
delay(800);
sine2.setAmp(0.5);
delay(1500);
sine2.setAmp(0);
}
}
else {
}
}
void keyPressed() {
if(key == '1') {
if(s1 > s2) {
println("Yay 1");
level = level + 1;
if (level == 2) {
low = 494;
high = 506;
}
if (level == 3) {
low = 497;
high = 503;
}
if (level == 4) {
low = 497;
high = 503;
}
if (level == 5) {
low = 497;
high = 503;
}
if (level == 6) {
low = 498.5;
high = 501.5;
}
if (level == 7) {
low = 498.5;
high = 501.5;
}
if (level == 8) {
low = 498.5;
high = 501.5;
}
if (level == 9) {
low = 499.25;
high = 500.75;
}
if (level == 10) {
low = 499.25;
high = 500.75;
}
if (level == 11) {
low = 499.25;
high = 500.75;
}
if (level == 12) {
low = 499.8125;
high = 500.1875;
}
if (level == 13) {
low = 499.8125;
high = 500.1875;
}
if (level == 14) {
low = 499.8125;
high = 500.1875;
}
}
else {
println("Nay 1");
level = level - 1;
}
}
else {
if(key == '2') {
if(s1 < s2) {
println("Yay 2");
level = level + 1;
if (level == 2) {
low = 494;
high = 506;
}
if (level == 3) {
low = 497;
high = 503;
}
if (level == 4) {
low = 497;
high = 503;
}
if (level == 5) {
low = 497;
high = 503;
}
if (level == 6) {
low = 498.5;
high = 501.5;
}
if (level == 7) {
low = 498.5;
high = 501.5;
}
if (level == 8) {
low = 498.5;
high = 501.5;
}
if (level == 9) {
low = 499.25;
high = 500.75;
}
if (level == 10) {
low = 499.25;
high = 500.75;
}
if (level == 11) {
low = 499.25;
high = 500.75;
}
if (level == 12) {
low = 499.8125;
high = 500.1875;
}
if (level == 13) {
low = 499.8125;
high = 500.1875;
}
if (level == 14) {
low = 499.8125;
high = 500.1875;
}
}
else {
println("Nay 2");
level = level - 1;
}
}
}
}
void stop()
{
out.close();
minim.stop();
super.stop();
}0
Comments
-
-
-
Your keyPressed function has duplicate code and FTLOG use a switch statement over all those if's.
Where you have the followingif (level == 1) { // high and low information for sine wave freq low = 450; high = 550; } if (level == 2) { low = 480; high = 520; } if (level == 3) { low = 490; high = 510; } etc etc
If the level is one it will continue to evaluate each and every if statement down the line.
Also those two big sets of if's in relation to the level are identical. So write it once and call it twice i.e. stick it in a method and pass the method the level parameter and as I said change the if's into a simple switch. The below should point you in the right direction. If you use it you should end up cutting about 100 lines of code out!private void SetLevels(int lowLevel, int highLevel) { low = lowLevel; high = highLevel; } private void demo(int level) { switch (level) { case 1: SetLevels(450, 550); break; case 2: SetLevels(480, 520); break; case 3: SetLevels(490, 510); break; case 4: SetLevels(494, 506); break; } }
Also think about putting the High and low values per level into some form of dictionary/array which ever you are more comfortable with or available to you. This is more for maintainability than anything else. If you want to change your highs and lows you will be happy you did.public class test { private struct SineRange { public SineRange(int low, int high) { this.Low = low; this.High = high; } public int Low; public int High; } private Dictionary<int, SineRange> SineRanges = new Dictionary<int, SineRange>(); private int low; private int high; private void InitRanges() { SineRanges.Add(1, new SineRange(450, 550)); SineRanges.Add(2, new SineRange(480, 520)); SineRanges.Add(3, new SineRange(490, 510)); SineRanges.Add(4, new SineRange(4494, 506)); } private void SetLevels(SineRange ranges) { low = ranges.Low; high = ranges.High; } private void demo(int level) { if (level < 15) SetLevels(SineRanges[level]); else { background(0); text("You completed the 16 levels.", 5, 100, 800, 100); text("You can consistently difference two tones as little as " + (high - low) + " Hz in difference! Well done!", 5, 200, 800, 100); text("Press R to reset to level 1. ", 5, 300, 800, 100); textFont(font3); text("Less than .75 Hz is exceptional.", 450, 320, 250, 200); text("Less than 1.5 Hz is very good.", 450, 340, 250, 50); text("Less than 6 Hz is normal.", 450, 360, 250, 50); text("Less than 12 Hz is below normal.", 450, 380, 250, 50); text("Less than 16 Hz is evidence of possible perception problems.", 450, 400, 250, 50); fill(255, 21, 0); text("Press E to exit.", 600, 450, 250, 50); } } }
There is some small pointers for a start
0 -
-
-
Advertisement
-
-
-
-
Advertisement