find max value in loop

bogwalrus

This has been wrecking my had last two days. Someone please put me out of my misery. I am trying to find the largest total earnings entered from the loop. In orange is the piece of code that should work but for some reason it is only giving me the last earnings input.

while( count <= noOfComp)
{

print("Enter Company: ");
companyName = kb.nextLine();

print("Number of hires: ");
noOfHires = kb.nextInt();
kb.nextLine();

//calculations
totalEarnings = noOfHires * 2500 + 10000;
System.out.println("Total Earnings from Big Sales Corp are :" + totalEarnings);

large = totalEarnings;
if(totalEarnings > large )
{
large = totalEarnings;
}


allTotalEarnings += totalEarnings;
count++;

}

LeinsterDub

Every time you loop you set large = totalEarnings thus totalEarnings > large is never true . set large =0 outside the loop

bogwalrus

LeinsterDub wrote: »

Every time you loop you set large = totalEarnings thus totalEarnings > large is never true . set large =0 outside the loop

This is just typical of me now. I spend two days trying to figure this out and the second I post looking for help i end up figuring it out.

I had large =0 already outside the loop but the one thing I did not try is to have large = totalEarnings also outside the loop. This has fixed my issue but now I am presented with a new problem.

I actually need the name of the company rather than its total earnings so need to figure how the max value can get me the particular company name.

thanks!

Synode

Put another variable called biggest or something (biggest = "") outside the while loop to store the name of the company with the largest sales. Then add a line to the if statement

if(totalEarnings > large )
{
large = totalEarnings;
biggest = companyName;
}

bogwalrus

I must thank you both LeinseterDub and Synode. There was no need for me to have large = totalEarnings as having large = 0 would have done the job.


It all works great now but I need to look over it to make sure I understand why.

Thanks again!!!:D