Advertisement
If you have a new account but are having problems posting or verifying your account, please email us on hello@boards.ie for help. Thanks :)
Hello all! Please ensure that you are posting a new thread or question in the appropriate forum. The Feedback forum is overwhelmed with questions that are having to be moved elsewhere. If you need help to verify your account contact hello@boards.ie
Java Project FYP
Options
-
11-04-2016 1:03pm#1
Comments
-
-
-
-
-
-
Advertisement
-
-
-
To that post? Not seeing it
Updated my src files. The boards file uploader had some issues the other day
I have the Hashmap in place but now its not saving my arraylists to a file.
HashmapCustomer.PNG
hashmap2.PNG
Also got the images working
When I was calling the setIcon method I never created the image new image !!!! I think i used ever constructor out there before I figured it out... 0 -
If the array of objects are accounts, can you not call
For(int I : : )
If acount[ I ].getAccount number() == search;
account[ I ].withdraw(amount);
Or do you have to know is it an "instance of" a certain type of account before withdraw is correct.
I had to do a similar banking project with an array of accounts, hashmaps would have been handy but at that stage of learning hashmaps and iterators wouldn't have even be mentioned let alone taught.
I can't see your code as I'm on the phone.
Ya at this stage Hashmaps are not needed, but there is a 10% for independent learning for the project so my lecturer encouraged me to do Hashmaps after seeing I was trying to implement them the other day
I blame guylikeme But After seeing hashmaps I like them, if I could just get them to work
Sorry for the slow replies, Have about 4 other projects and this is the last one I have to submit but does carry 10credit 0 -
In your map you are using the first name as key. That is bad. Hashmaps work by hashing the key. Adding two names of the same name will be problematic. If you want to do it this way just use the customer as key. In the customer class you implement the hashcode and equals method. Again google is your friend. Should help towards extra 10%.
There is a standard rule called is a has a rule for class relationships best practice.
Example an account is not a customer so you would never extend it.
But a customer has an account so you could have it as a class member. Your standard array will work nicely with this as you can call the account methods on that member with your customer reference.
As you have a savings account also then what your teacher wants you to do is create an abstract account class and extend that class with current account and savings account class. Ensure only the required.
Iterate your list of customers and find the one you want then call this
example [PHP]customer.getAccount.deposit(double deposit){logic}[/PHP]
From what I see id guess you will be marked on the java basics i.e. classes, dependancies, flow control etc. I'd definitely change your class relationships anyway.
NB your arraylist of customers is saving on my machine 0 -
Advertisement
-
In your map you are using the first name as key. That is bad. Hashmaps work by hashing the key. Adding two names of the same name will be problematic. If you want to do it this way just use the customer as key. In the customer class you implement the hashcode and equals method. Again google is your friend. Should help towards extra 10%.
There is a standard rule called is a has a rule for class relationships best practice.
Example an account is not a customer so you would never extend it.
But a customer has an account so you could have it as a class member. Your standard array will work nicely with this as you can call the account methods on that member with your customer reference.
As you have a savings account also then what your teacher wants you to do is create an abstract account class and extend that class with current account and savings account class. Ensure only the required.
Iterate your list of customers and find the one you want then call this
example [PHP]customer.getAccount.deposit(double deposit){logic}[/PHP]
From what I see id guess you will be marked on the java basics i.e. classes, dependancies, flow control etc. I'd definitely change your class relationships anyway.
NB your arraylist of customers is saving on my machine
Can I start by saying thanks "yes there" for taking the time and effort in writing such a clear and well defined reply,
Just cleared up the extends customer into account and working on making it abstract for the subclasses at the moment thanks for the comments on that we barely touched on abstract classes, doing a hdip in Java we are moving quick quick
Still trying to wrap my head around the hashmap ideas you talked about. Ill work on it tomorrow.
Btw would love to get you opinion on my loop method I have for blocking blank input from a user.
heres the method :
[PHP]
private String getNonBlankInput(String prompt) {
String input = JOptionPane.showInputDialog(prompt);
while (input.equals("")) {
JOptionPane.showMessageDialog(null, "Cannot accept blank entries!");
input = JOptionPane.showInputDialog(prompt);
}
return input;
}[/PHP]
so when asking for customer data I call the method here :
[PHP]Customer c1 = new Customer();
c1.setFirstName(JOptionPane.showInputDialog(null, getNonBlankInput("What is the Customers First Name:")));[/PHP]
Is this an accepted way to validate data input? Seems to work ok so far :rolleyes:0 -
-
No problem. If it works it is an acceptable way, another question is can it be done better, you should always be asking yourself this. If I was doing it I would compare against a regular expression and not an empty string. Reg Exs at first appear difficult but they are easy with practice. You would use the The pattern and matcher class for this.
As an added learning experience Id stress you to look up the docs for both of these classes before you go googling the solution. In most of your development life you will be using libraries so understanding how to read and use classes like these at this stage will really help you.
Thanks Again. I did the suggestions that you suggested :cool:
Im the only one in the class that's using Abstract classes in my project, also I think i have Customer/savingAccount and CurrentAccount all with hashmaps now.
Also I cleared up the relationship with account inheirating from Customer. I intend to talk about that i my documentation.
Just need to figure out how to iterate through them now
Also added some icons and some input validations for setAge();0 -
Thanks Again. I did the suggestions that you suggested :cool:
Im the only one in the class that's using Abstract classes in my project, also I think i have Customer/savingAccount and CurrentAccount all with hashmaps now.
Also I cleared up the relationship with account inheirating from Customer. I intend to talk about that i my documentation.
Just need to figure out how to iterate through them now
Also added some icons and some input validations for setAge();
Also having some issues with loading my saved files into my program, is there any way to do this automatically?
I have this method:
[PHP] public static void getCustomers(ArrayList myCustomers) throws FileNotFoundException, IOException, ClassNotFoundException {
ObjectInputStream is = new ObjectInputStream(new FileInputStream("Customer.data"));
myCustomers = (ArrayList<Customer>) is.readObject(); // note the typecast
is.close();
}[/PHP]
I called the method at the top on the top of my BankSYS file. but its not loading it0
Advertisement